From dd2b96892473ae3d51813fcfa6978aa47cda2d00 Mon Sep 17 00:00:00 2001
From: pierreozoux <pierre@ozoux.net>
Date: Mon, 27 Oct 2014 12:32:21 +0000
Subject: [PATCH] Improves code-style

---
 unit-files/haproxy-confd.service    | 18 +++++++++++-------
 unit-files/haproxy.service          | 18 +++++++++++-------
 unit-files/nginx-discovery@.service | 11 ++++++-----
 unit-files/nginx-importer@.service  |  4 +++-
 unit-files/nginx@.service           | 16 ++++++++++------
 unit-files/postfix.service          | 16 ++++++++++------
 6 files changed, 51 insertions(+), 32 deletions(-)

diff --git a/unit-files/haproxy-confd.service b/unit-files/haproxy-confd.service
index 99ff82e..cc74602 100644
--- a/unit-files/haproxy-confd.service
+++ b/unit-files/haproxy-confd.service
@@ -1,19 +1,23 @@
 [Unit]
 Description=%p
-After=docker.service
+
+# Requirements
 Requires=docker.service
 
+# Dependency ordering
+After=docker.service
+
 [Service]
 Restart=always
 TimeoutStartSec=0
 ExecStartPre=-/usr/bin/docker kill %p
 ExecStartPre=-/usr/bin/docker rm %p
-ExecStart=/usr/bin/docker run\
---name %p\
--v /data/server-wide/haproxy/:/etc/haproxy/\
--v /data/indiehosters/confd/:/etc/confd/\
--v /var/run/docker.sock:/var/run/docker.sock\
-indiehosters/confd
+ExecStart=/usr/bin/docker run \
+  --name %p \
+  -v /data/server-wide/haproxy/:/etc/haproxy/ \
+  -v /data/indiehosters/confd/:/etc/confd/ \
+  -v /var/run/docker.sock:/var/run/docker.sock \
+  indiehosters/confd
 ExecReload=/usr/bin/docker restart %p
 ExecStop=/usr/bin/docker stop %p
 
diff --git a/unit-files/haproxy.service b/unit-files/haproxy.service
index 93b9830..5a9b6bf 100644
--- a/unit-files/haproxy.service
+++ b/unit-files/haproxy.service
@@ -1,19 +1,23 @@
 [Unit]
 Description=%p
-After=docker.service
+
+# Requirements
 Requires=docker.service
 
+# Dependency ordering
+After=docker.service
+
 [Service]
 Restart=always
 TimeoutStartSec=0
 ExecStartPre=-/usr/bin/docker kill %p
 ExecStartPre=-/usr/bin/docker rm %p
-ExecStart=/usr/bin/docker run\
---name %p\
--v /data/server-wide/haproxy:/etc/haproxy\
--p 80:80\
--p 443:443\
-indiehosters/haproxy
+ExecStart=/usr/bin/docker run \
+  --name %p \
+  -v /data/server-wide/haproxy:/etc/haproxy \
+  -p 80:80 \
+  -p 443:443 \
+  indiehosters/haproxy
 ExecReload=/usr/bin/docker restart %p
 ExecStop=/usr/bin/docker stop %p
 
diff --git a/unit-files/nginx-discovery@.service b/unit-files/nginx-discovery@.service
index 25c620c..8b7a16b 100644
--- a/unit-files/nginx-discovery@.service
+++ b/unit-files/nginx-discovery@.service
@@ -5,17 +5,18 @@ Description=%p for %i etcd registration
 Requires=etcd.service
 Requires=nginx@%i.service
 
-# Dependency ordering and binding
+# Dependency ordering
 After=etcd.service
 After=nginx@%i.service
+
+# Dependency binding
 BindsTo=nginx@%i.service
 
 [Service]
-
 TimeoutStartSec=0
 # Start
 ## Test whether service is accessible and then register useful information
-ExecStart=/bin/bash -c '\
+ExecStart=/bin/bash -c ' \
   sleep 3; \
   while true; do \
     app=`echo %p | cut -d"-" -f1`; \
@@ -30,6 +31,6 @@ ExecStart=/bin/bash -c '\
   done'
 
 # Stop
-ExecStop=/bin/bash -ceux '\
-  app=`echo %p | cut -d"-" -f1`;\
+ExecStop=/bin/bash -ceux ' \
+  app=`echo %p | cut -d"-" -f1`; \
   /usr/bin/etcdctl rm /services/$app/%i
diff --git a/unit-files/nginx-importer@.service b/unit-files/nginx-importer@.service
index 3a0e439..9907c6e 100644
--- a/unit-files/nginx-importer@.service
+++ b/unit-files/nginx-importer@.service
@@ -1,5 +1,7 @@
-[Unit]  
+[Unit]
 Description=nginx importer
+
+# Dependency ordering
 Before=nginx@%i.service
 
 [Service]
diff --git a/unit-files/nginx@.service b/unit-files/nginx@.service
index 7040eb3..438abc1 100644
--- a/unit-files/nginx@.service
+++ b/unit-files/nginx@.service
@@ -1,22 +1,26 @@
 [Unit]
 Description=%p-%i
-After=docker.service
+
+# Requirements
 Requires=docker.service
 Requires=etcd.service
 Requires=%p-importer@%i.service
-After=%p-importer@%i.service
 Requires=%p-discovery@%i.service
+
+# Dependency ordering
 Before=%p-discovery@%i.service
+After=docker.service
+After=%p-importer@%i.service
 
 [Service]
 Restart=always
 TimeoutStartSec=0
 ExecStartPre=-/usr/bin/docker kill %p-%i
 ExecStartPre=-/usr/bin/docker rm %p-%i
-ExecStart=/usr/bin/docker run\
---name %p-%i\
--v /data/per-user/%i/%p/data/www-content:/app\
-indiehosters/nginx
+ExecStart=/usr/bin/docker run \
+  --name %p-%i \
+  -v /data/per-user/%i/%p/data/www-content:/app \
+  indiehosters/nginx
 ExecReload=/usr/bin/docker restart %p-%i
 ExecStop=/usr/bin/docker stop %p-%i
 
diff --git a/unit-files/postfix.service b/unit-files/postfix.service
index bcb06a6..0188ff2 100644
--- a/unit-files/postfix.service
+++ b/unit-files/postfix.service
@@ -1,18 +1,22 @@
 [Unit]
 Description=%p
-After=docker.service
+
+# Requirements
 Requires=docker.service
 
+# Dependency ordering
+After=docker.service
+
 [Service]
 Restart=always
 TimeoutStartSec=0
 ExecStartPre=-/usr/bin/docker kill %p
 ExecStartPre=-/usr/bin/docker rm %p
-ExecStart=/usr/bin/docker run\
---name %p\
--p 25:25\
--v /data/server-wide/postfix/:/data\
-indiehosters/postfix-forwarder
+ExecStart=/usr/bin/docker run \
+  --name %p \
+  -v /data/server-wide/postfix/:/data \
+  -p 25:25 \
+  indiehosters/postfix-forwarder
 ExecReload=/usr/bin/docker restart %p
 ExecStop=/usr/bin/docker stop %p
 
-- 
GitLab