diff --git a/src/main/java/sh/libre/scim/core/GroupScimService.java b/src/main/java/sh/libre/scim/core/GroupScimService.java index 0648f10c106c3f7c918ad83d8fb743aef3d5fd2c..99c8c5cb52f9acdf2e33da466bbf94e783a1542e 100644 --- a/src/main/java/sh/libre/scim/core/GroupScimService.java +++ b/src/main/java/sh/libre/scim/core/GroupScimService.java @@ -99,13 +99,14 @@ public class GroupScimService extends AbstractScimService<GroupModel, Group> { logger.debug(userMapping.getExternalIdAsEntityOnRemoteScimId()); logger.debug(userMapping.getIdAsKeycloakId()); groupMember.setValue(userMapping.getExternalIdAsEntityOnRemoteScimId().asString()); - URI ref = new URI(String.format("Users/%s", userMapping.getExternalIdAsEntityOnRemoteScimId())); + String refString = String.format("Users/%s", userMapping.getExternalIdAsEntityOnRemoteScimId().asString()); + URI ref = new URI(refString); groupMember.setRef(ref.toString()); group.addMember(groupMember); } catch (NoSuchElementException e) { logger.warnf("member %s not found for group %s", member, groupModel.getId()); } catch (URISyntaxException e) { - logger.warnf("bad ref uri"); + logger.warnf("bad ref uri for member " + member); } } return group; diff --git a/src/main/java/sh/libre/scim/core/ScimClient.java b/src/main/java/sh/libre/scim/core/ScimClient.java index 22bfa0e7ec06a0472cc56be271ffc1cab0cc3132..9189ad308b426ee33f884b4b4b4a97e7048345fe 100644 --- a/src/main/java/sh/libre/scim/core/ScimClient.java +++ b/src/main/java/sh/libre/scim/core/ScimClient.java @@ -83,6 +83,7 @@ public class ScimClient<S extends ResourceNode> implements AutoCloseable { private void checkResponseIsSuccess(ServerResponse<S> response) { if (!response.isSuccess()) { + LOGGER.warn("[SCIM] Issue on SCIM Server response "); LOGGER.warn(response.getResponseBody()); LOGGER.warn(response.getHttpStatus()); } @@ -98,7 +99,6 @@ public class ScimClient<S extends ResourceNode> implements AutoCloseable { public void replace(EntityOnRemoteScimId externalId, S scimForReplace) { Retry retry = retryRegistry.retry("replace-%s".formatted(externalId.asString())); - LOGGER.warn(scimForReplace); ServerResponse<S> response = retry.executeSupplier(() -> scimRequestBuilder .update(getResourceClass(), getScimEndpoint(), externalId.asString()) .setResource(scimForReplace) diff --git a/src/main/java/sh/libre/scim/core/ScimDispatcher.java b/src/main/java/sh/libre/scim/core/ScimDispatcher.java index 6be68dc3d2cd3c9bf48968474e1b18e1935cc5fa..8154bb393024c3fe3c7d28b87b8848dc69b2b324 100644 --- a/src/main/java/sh/libre/scim/core/ScimDispatcher.java +++ b/src/main/java/sh/libre/scim/core/ScimDispatcher.java @@ -146,7 +146,7 @@ public class ScimDispatcher { private void logAndRollback(ScrimProviderConfiguration scimServerConfiguration, ScimPropagationException e) { logger.error("[SCIM] Error while propagating to SCIM endpoint " + scimServerConfiguration.getId(), e); - session.getTransactionManager().rollback(); + // TODO session.getTransactionManager().rollback(); } private void initializeClientsIfNeeded() {