Skip to content
Unverified Commit 89e9d107 authored by Ankit R Gadiya's avatar Ankit R Gadiya
Browse files

fix: accepting pointer to empty struct directly now

The update function was using reflect to determine the object type and
creating new pointer. First of all, it was actually returning the
pointer to pointer to the object which does not implement
interfaces.Object so all reflect calls were failing.

I tried to fix that with Elem call but that returns the type with zero
value and since the type is pointer its zero value is nil. However
client requires pointer to empty struct not nil pointer. I have not
figured out a way so I added the comment. For now I'm accepting the
ExistingObject empty struct directly and using it.
parent 412f6011
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment