Skip to content
Snippets Groups Projects
Commit 3009edf1 authored by Brendan Le Ny's avatar Brendan Le Ny Committed by Alex Morel
Browse files

Remove pointless exception encapsulation

parent c793c138
No related branches found
No related tags found
1 merge request!3Sonar refactoring
......@@ -70,16 +70,11 @@ public class ScimClient<S extends ResourceNode> implements AutoCloseable {
);
}
Retry retry = retryRegistry.retry("create-%s".formatted(id.asString()));
ServerResponse<S> response = retry.executeSupplier(() -> {
try {
return scimRequestBuilder
.create(getResourceClass(), getScimEndpoint())
.setResource(scimForCreation)
.sendRequest();
} catch (ResponseException e) {
throw new RuntimeException(e);
}
});
ServerResponse<S> response = retry.executeSupplier(() -> scimRequestBuilder
.create(getResourceClass(), getScimEndpoint())
.setResource(scimForCreation)
.sendRequest()
);
checkResponseIsSuccess(response);
S resource = response.getResource();
return resource.getId()
......@@ -104,29 +99,20 @@ public class ScimClient<S extends ResourceNode> implements AutoCloseable {
public void replace(EntityOnRemoteScimId externalId, ResourceNode scimForReplace) {
Retry retry = retryRegistry.retry("replace-%s".formatted(externalId.asString()));
ServerResponse<S> response = retry.executeSupplier(() -> {
try {
return scimRequestBuilder
.update(getResourceClass(), getScimEndpoint(), externalId.asString())
.setResource(scimForReplace)
.sendRequest();
} catch (ResponseException e) {
throw new RuntimeException(e);
}
});
ServerResponse<S> response = retry.executeSupplier(() -> scimRequestBuilder
.update(getResourceClass(), getScimEndpoint(), externalId.asString())
.setResource(scimForReplace)
.sendRequest()
);
checkResponseIsSuccess(response);
}
public void delete(EntityOnRemoteScimId externalId) {
Retry retry = retryRegistry.retry("delete-%s".formatted(externalId.asString()));
ServerResponse<S> response = retry.executeSupplier(() -> {
try {
return scimRequestBuilder.delete(getResourceClass(), getScimEndpoint(), externalId.asString())
.sendRequest();
} catch (ResponseException e) {
throw new RuntimeException(e);
}
});
ServerResponse<S> response = retry.executeSupplier(() -> scimRequestBuilder
.delete(getResourceClass(), getScimEndpoint(), externalId.asString())
.sendRequest()
);
checkResponseIsSuccess(response);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment