Skip to content
  1. Sep 22, 2019
    • Ankit R Gadiya's avatar
      dfe673e0
    • Ankit R Gadiya's avatar
      fix: accepting pointer to empty struct directly now · 89e9d107
      Ankit R Gadiya authored
      The update function was using reflect to determine the object type and
      creating new pointer. First of all, it was actually returning the
      pointer to pointer to the object which does not implement
      interfaces.Object so all reflect calls were failing.
      
      I tried to fix that with Elem call but that returns the type with zero
      value and since the type is pointer its zero value is nil. However
      client requires pointer to empty struct not nil pointer. I have not
      figured out a way so I added the comment. For now I'm accepting the
      ExistingObject empty struct directly and using it.
      89e9d107
    • Ankit R Gadiya's avatar
      fix: checking the underlying error · 412f6011
      Ankit R Gadiya authored
      The create function wraps errors which causes Kubernetes error
      functions to not detect the specific types of errors. This commit
      fixes it by checking the underlying error instead of error directly.
      
      Also, all calls were calling update (even with successful
      create). This commit adds a check for only those where create failed
      with IsAlreadyExists error will it call update.
      412f6011
    • Ankit R Gadiya's avatar
      fix: added check for non-nil error · 9bce3ace
      Ankit R Gadiya authored
      delete function was not checking for error and directly checking for
      specific type of error. This was leading to every call returning
      error. This commit fixed it by adding a check for non-nil errors
      first.
      9bce3ace
  2. Sep 19, 2019
  3. Sep 18, 2019
  4. Sep 12, 2019
  5. Aug 12, 2019
Loading